test: 补强架构收敛导入门禁
This commit is contained in:
parent
e66d3fd824
commit
c3b0476dcc
@ -1,15 +1,27 @@
|
||||
import { existsSync, readdirSync, readFileSync, statSync } from 'node:fs';
|
||||
import { join, relative } from 'node:path';
|
||||
import {
|
||||
dirname,
|
||||
join,
|
||||
normalize,
|
||||
relative,
|
||||
resolve,
|
||||
sep,
|
||||
} from 'node:path';
|
||||
|
||||
const repoRoot = join(__dirname, '..', '..');
|
||||
const srcRoot = join(repoRoot, 'src');
|
||||
|
||||
const legacyRoots = ['admin', 'blog', 'minio', 'wordpress', 'qqbot'];
|
||||
const legacyRootNames = ['admin', 'blog', 'minio', 'wordpress', 'qqbot'];
|
||||
const legacyRootPaths = legacyRootNames.map((root) => join(srcRoot, root));
|
||||
const moduleRoots = ['admin', 'asset', 'blog', 'wordpress', 'qqbot'];
|
||||
const qqbotRoots = ['core', 'napcat', 'plugin-platform', 'plugins'];
|
||||
|
||||
function isDirectory(path: string): boolean {
|
||||
return existsSync(path) && statSync(path).isDirectory();
|
||||
}
|
||||
|
||||
function listFiles(dir: string): string[] {
|
||||
if (!existsSync(dir)) return [];
|
||||
if (!isDirectory(dir)) return [];
|
||||
return readdirSync(dir).flatMap((entry) => {
|
||||
const absolute = join(dir, entry);
|
||||
const stat = statSync(absolute);
|
||||
@ -18,19 +30,51 @@ function listFiles(dir: string): string[] {
|
||||
});
|
||||
}
|
||||
|
||||
function readTextFiles(dir: string): Array<{ file: string; text: string }> {
|
||||
function readTextFiles(
|
||||
dir: string,
|
||||
): Array<{ absolute: string; file: string; text: string }> {
|
||||
return listFiles(dir)
|
||||
.filter((file) => /\.(ts|tsx|vue|js|mjs|cjs)$/.test(file))
|
||||
.map((file) => ({
|
||||
absolute: file,
|
||||
file: relative(repoRoot, file).replace(/\\/g, '/'),
|
||||
text: readFileSync(file, 'utf8'),
|
||||
}));
|
||||
}
|
||||
|
||||
function extractImportSpecifiers(text: string): string[] {
|
||||
const importPattern =
|
||||
/(?:import|export)\s+(?:type\s+)?(?:[^'"]*?\s+from\s+)?['"]([^'"]+)['"]|import\(\s*['"]([^'"]+)['"]\s*\)/g;
|
||||
return [...text.matchAll(importPattern)]
|
||||
.map((match) => match[1] || match[2])
|
||||
.filter((specifier): specifier is string => Boolean(specifier));
|
||||
}
|
||||
|
||||
function resolvesInsideLegacyRoot(fromFile: string, specifier: string): boolean {
|
||||
let resolved: string | null = null;
|
||||
if (specifier === '@') resolved = srcRoot;
|
||||
if (specifier.startsWith('@/')) {
|
||||
resolved = join(srcRoot, specifier.slice(2));
|
||||
}
|
||||
if (specifier.startsWith('.')) {
|
||||
resolved = resolve(dirname(fromFile), specifier);
|
||||
}
|
||||
if (!resolved) return false;
|
||||
|
||||
const normalized = normalize(resolved);
|
||||
return legacyRootPaths.some((legacyRoot) => {
|
||||
const normalizedLegacy = normalize(legacyRoot);
|
||||
return (
|
||||
normalized === normalizedLegacy ||
|
||||
normalized.startsWith(`${normalizedLegacy}${sep}`)
|
||||
);
|
||||
});
|
||||
}
|
||||
|
||||
describe('architecture convergence', () => {
|
||||
it('does not keep API legacy source roots', () => {
|
||||
const existing = legacyRoots.filter((root) =>
|
||||
existsSync(join(srcRoot, root)),
|
||||
const existing = legacyRootNames.filter((root) =>
|
||||
isDirectory(join(srcRoot, root)),
|
||||
);
|
||||
|
||||
expect(existing).toEqual([]);
|
||||
@ -38,7 +82,7 @@ describe('architecture convergence', () => {
|
||||
|
||||
it('keeps all business modules under src/modules', () => {
|
||||
const missing = moduleRoots.filter(
|
||||
(root) => !existsSync(join(srcRoot, 'modules', root)),
|
||||
(root) => !isDirectory(join(srcRoot, 'modules', root)),
|
||||
);
|
||||
|
||||
expect(missing).toEqual([]);
|
||||
@ -46,29 +90,30 @@ describe('architecture convergence', () => {
|
||||
|
||||
it('keeps QQBot subdomains under src/modules/qqbot', () => {
|
||||
const missing = qqbotRoots.filter(
|
||||
(root) => !existsSync(join(srcRoot, 'modules', 'qqbot', root)),
|
||||
(root) => !isDirectory(join(srcRoot, 'modules', 'qqbot', root)),
|
||||
);
|
||||
|
||||
expect(missing).toEqual([]);
|
||||
});
|
||||
|
||||
it('does not import old roots from src/modules', () => {
|
||||
const forbidden = /@\/(?:admin|blog|minio|wordpress|qqbot)\//;
|
||||
const offenders = readTextFiles(join(srcRoot, 'modules'))
|
||||
.filter(({ text }) => forbidden.test(text))
|
||||
.map(({ file }) => file);
|
||||
.flatMap(({ absolute, file, text }) =>
|
||||
extractImportSpecifiers(text)
|
||||
.filter((specifier) => resolvesInsideLegacyRoot(absolute, specifier))
|
||||
.map((specifier) => `${file} -> ${specifier}`),
|
||||
);
|
||||
|
||||
expect(offenders).toEqual([]);
|
||||
});
|
||||
|
||||
it('does not import old roots from app module', () => {
|
||||
const appModule = readFileSync(join(srcRoot, 'app.module.ts'), 'utf8');
|
||||
const appModulePath = join(srcRoot, 'app.module.ts');
|
||||
const appModule = readFileSync(appModulePath, 'utf8');
|
||||
const offenders = extractImportSpecifiers(appModule).filter((specifier) =>
|
||||
resolvesInsideLegacyRoot(appModulePath, specifier),
|
||||
);
|
||||
|
||||
expect(appModule).not.toMatch(
|
||||
/from ['"]\.\/(?:admin|blog|minio|wordpress|qqbot)/,
|
||||
);
|
||||
expect(appModule).not.toMatch(
|
||||
/from ['"]@\/(?:admin|blog|minio|wordpress|qqbot)\//,
|
||||
);
|
||||
expect(offenders).toEqual([]);
|
||||
});
|
||||
});
|
||||
|
||||
Loading…
Reference in New Issue
Block a user